Fix trim_trailing_whitespace typo in .editorconfig file
#6349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trim_trailing_spaces seems to have been an older proposal for the name of this property but trim_trailing_whitespace is what was finally settled on. trim_trailing_whitespace already appears twice in this file. https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#trim_trailing_whitespace
Alhadis
approved these changes
Apr 1, 2023
Alhadis
changed the title
trim_trailing_whitespace typo in .editorconfig file
It's one of the four possible names for this option suggested here: https://github.com/editorconfig/editorconfig/wiki/Property-research:-Trim-trailing-spaces |
Judging from $ git clone https://github.com/editorconfig/editorconfig.wiki.git
$ cd editorconfig.wiki/
$ git blame 'Property-research:-Trim-trailing-spaces.md'
41e31d80 (sindresorhus 2012-07-01 07:03:56 -0700 7) ## Naming ideas
41e31d80 (sindresorhus 2012-07-01 07:03:56 -0700 8)
3c852fbe (David D Lowe 2016-12-02 12:14:34 +0100 9) - trim_trailing_whitespace (note: this is the name that ended up being chosen)
99a257a6 (Trey Hunner 2012-07-02 08:18:14 -0700 10) - trim_trailing_spaces
41e31d80 (sindresorhus 2012-07-01 07:03:56 -0700 11) - allow_trailing_space
a241dde5 (Alexander Sashnov 2018-08-25 23:46:16 +0700 12) - strip_trailing_spaceSo, as far back as mid-2012, and probably long before it saw widespread adoption. Regardless, this was clearly a typo, because both the correct and incorrect spellings were added in the same commit (by none other than yours truly); cf. lines 9 and 29. |
lildude
approved these changes
Apr 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
trim_trailing_spacesseems to have been an older proposal for the name of this property buttrim_trailing_whitespaceis what was finally settled on.trim_trailing_whitespacealready appears twice in this file.https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#trim_trailing_whitespace
Cc: @Alhadis who added this file originally